🐛 Fix label on Archetype detail drawer, Reviews tab #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "Reviews" instead of "Review" on the Archetype details drawer Reviews tab. This keeps the terms used on the tab labels all consistent. Resolves: https://issues.redhat.com/browse/MTA-1888 Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Dec 16, 2023
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jan 3, 2024
After some discussions in the Jira ticket, the archetype detail drawer tab should be named "Review" since an archetype will only have a single review. The application detail drawer tab will remain "Reviews" since applications can inherit multiple reviews from multiple archetype matches. Follow up to: konveyor#1626 Resolves: https://issues.redhat.com/browse/MTA-1888 Signed-off-by: Scott J Dickerson <[email protected]>
ibolton336
pushed a commit
that referenced
this pull request
Jan 3, 2024
After some discussions in the Jira ticket, the archetype detail drawer tab should be named "Review" since an archetype will only have a single review. The application detail drawer tab will remain "Reviews" since applications can inherit multiple reviews from multiple archetype matches. Follow up to: #1626 Resolves: https://issues.redhat.com/browse/MTA-1888 Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "Reviews" instead of "Review" on the Archetype details drawer Reviews tab. This keeps the terms used on the tab labels all consistent.
Resolves: https://issues.redhat.com/browse/MTA-1888